Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix plane artifacts #138

Merged
merged 1 commit into from
Jan 30, 2024
Merged

fix plane artifacts #138

merged 1 commit into from
Jan 30, 2024

Conversation

cmeissl
Copy link
Contributor

@cmeissl cmeissl commented Jan 28, 2024

depends on Smithay/smithay#1297

@kchibisov does this fix the issues you mentioned?

@kchibisov
Copy link
Contributor

@kchibisov does this fix the issues you mentioned?

No. My issue is likely something else, since once I exit niri I can't actually start my greater and I fail to set crtc. I think it's just a driver bug.

@cmeissl
Copy link
Contributor Author

cmeissl commented Jan 28, 2024

Okay, just to add something that surprised me. sway does not seem to clear planes on session resume, so when switching from a compositor that used overlay planes, but did not clear it on session suspend it will be left over and still show up in sway.

@cmeissl cmeissl force-pushed the fix/plane_artifacts branch from 51b7486 to a3439e5 Compare January 28, 2024 19:48
changing the "ACTIVE" property of a surface requires
to re-evaluate the surface state.
@cmeissl cmeissl force-pushed the fix/plane_artifacts branch from a3439e5 to 0e1aa1c Compare January 29, 2024 18:40
@cmeissl cmeissl marked this pull request as ready for review January 29, 2024 18:43
@cmeissl cmeissl mentioned this pull request Jan 29, 2024
@YaLTeR YaLTeR merged commit b813f99 into YaLTeR:main Jan 30, 2024
5 checks passed
@YaLTeR
Copy link
Owner

YaLTeR commented Jan 30, 2024

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants