Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for longer student IDs and fix crash when students forget to logout #7

Merged
merged 2 commits into from
Nov 20, 2019

Conversation

hdsbbrooks
Copy link
Contributor

Our school uses 14 digit bar codes on student cards. A pretty minor change but it might help someone else without the capacity to change and rebuild it themselves.

@leeaidan
Copy link

leeaidan commented Nov 5, 2019

Is there a way to develop a page in google sheets or an external GUI that displays a list of who is currently signed in? I feel as if this feature could benefit mentors or teachers who wanted to see who is in the lab at a certain time.

@Daltz333
Copy link
Member

Daltz333 commented Nov 5, 2019

GrizzlyTime has a column that has shows which students are logged in or not in Google Sheets

image

SEVERE: java.time.format.DateTimeParseException: Text '-6:12:38' could not be parsed at index 0

A negative value is checked for and the error flag is set but this code was running irrespective of the error flag status.  Moved the crashing lines so they only evaluate if the error flag is not set.
@hdsbbrooks hdsbbrooks changed the title Allow for longer student IDs. Allow for longer student IDs and fix crash when students forget to logout Nov 6, 2019
@hdsbbrooks
Copy link
Contributor Author

I ran into a crash bug when students forgot to log out for the day.

java.time.format.DateTimeParseException: Text '-6:12:38' could not be parsed at index 0

A negative value is checked for and the error flag is set but this code was running irrespective of the error flag status. Moved the crashing lines so they only evaluate if the error flag is not set. I fixed it and added to this pull request.

@Daltz333 Daltz333 merged commit e9768f4 into YCSRobotics:master Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants