Lyric Bar Enhancements #974
Merged
+86
−78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Improve implementation of upcoming lyric bar: the style of how the current phrase appears in the lyric bar makes delaying upcoming phrase display feel off. Now, given that the next phrase connects with the current one, the upcoming phrase will always appear. The only exception being for upcoming phrases that have length shorter than a certain threshold - where they won't appear at all. + Add fadein and fadeout of both sets of lyrics. + Remove `UpcomingLyricsTime` setting. + Hold the stringbuilder as a member variable instead of creating a new one every time. Just have to clear it before constructing a line.
Just for leniency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UpcomingLyricsTimesetting.