Fix some issues with score database querying/caching, and allow selecting whether high-score display searches all difficulties or only the highest difficulty #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
TheNathannator
commented
Jan 27, 2025
TheNathannator
commented
- Highest score and percentage are now always queried separately from each other for the high score display.
- The high score display now has the option to choose between whether all difficulties are searched for the highest score/percentage, or whether only the highest difficulty is used.
- This defaults to the highest difficulty only option, since, from a naive/ideal perspective, it provides a more natural way of showcasing progression up the difficulty ladder and accounts for most general cases.
… displaying independently on song list
…nly the highest difficulty
…f manually checking score values
…fferent difficulties
EliteAsian123
requested changes
Jan 27, 2025
|
The one high score mode I didn't check lol, thanks for catching that! |
theli-ua
pushed a commit
to theli-ua/YARG
that referenced
this pull request
Feb 2, 2025
…ting whether high-score display searches all difficulties or only the highest difficulty (YARC-Official#953) * Tidy up score database queries into a helper type * Better represent results of queries which only pull song checksums * Redo highest score/percentage queries to fix percentage and score not displaying independently on song list * Allow selecting whether high-score display uses all difficulties or only the highest difficulty * Re-query database when caching new high scores on song end, instead of manually checking score values * Invalidate score cache when switching history modes * Clearly indicate when percent and score on the song list come from different difficulties * Don't show score difficulty badge when high score display is disabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.