-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/#90 search api #94
Conversation
고생하셨습니다! |
.init( | ||
page: pageable.page, | ||
size: pageable.size, | ||
sort: pageable.sort | ||
), | ||
true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
init으로 바로 때려박는거보다 request라는 상수하나 만들고 인자넣는방식이 더 좋아보이긴합니다! true가 너무 불쌍하게 떨어져있음ㅠ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넵!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생많으셨습니다! 검색어관련해서 userdefaults도 잘 구현해주신 것 같아요! 크게 문제되는 부분은 없으나 여전히 case let이 사용되지 않은 부분이 많이 보입니다. 일단 approve는 하겠지만 보이면 다음 PR때 수정해주세엽~~!
#️⃣연관된 이슈
📝작업 내용
스크린샷 (선택)
💬리뷰 요구사항(선택)
아직 서버쪽에서 검색 api가 제대로 완성되지 않은건지, 검색 결과가 좀 이상하니 참고 바라겠습니다.(카테고리 필터가 안됨)해결 완!close #90