포킷 추가 및 수정 UI 구성 #54
Merged
포킷 추가 및 수정 UI 구성 #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- AddCategory -> CategorySetting으로 이름변경에 따른 기존 폴더 제거
- UI 및 기능 둘다 작업 완
ITlearning
approved these changes
Jul 26, 2024
| let categoryId: Int | ||
| let categoryName: String | ||
| /// var: 포킷 수정 / 추가에서 이미지를 할당할 수 있음 | ||
| var categoryImage: CategorySettingImageMock |
There was a problem hiding this comment.
(제가 코드를 다 보지 않아서 이해를 잘 못한걸수도 있읍니다.)
이 데이터는 직접 접근해서 변경하는걸까요?
아니면 변경하는 곳이 따로 있는걸까요?
| import Util | ||
|
|
||
| @Reducer | ||
| public struct PokitCategorySettingFeature { |
There was a problem hiding this comment.
(이건 순수한 궁금입니다)
되도록이면 public 접근 제한자를 사용하시는 것 같은데, 명시하는 이유가 있을까요?
There was a problem hiding this comment.
(이건 순수한 궁금입니다) 되도록이면 public 접근 제한자를 사용하시는 것 같은데, 명시하는 이유가 있을까요?
외부 모듈에서 쓰이기 때문입니다..!!
| VStack(spacing: 0) { | ||
| thumbnailSection | ||
| pokitNameSection | ||
| if !store.itemList.isEmpty { |
There was a problem hiding this comment.
이런거 쌈@뽕하게 처리하는 방식 하나만 공유해봅니다 ㅎㅎㅎㅎ
회사에서 이렇게 쓰고 있길래..
extension Bool {
func not() -> Bool { !self }
}이렇게 선언해서
store.itemList.isEmpty.not() 이렇게 하면 가독성 좋고, 무엇보다 깐지납니다. (??)
ShapeKim98
approved these changes
Jul 26, 2024
| import Util | ||
|
|
||
| @Reducer | ||
| public struct PokitCategorySettingFeature { |
There was a problem hiding this comment.
(이건 순수한 궁금입니다) 되도록이면 public 접근 제한자를 사용하시는 것 같은데, 명시하는 이유가 있을까요?
외부 모듈에서 쓰이기 때문입니다..!!
| VStack(spacing: 0) { | ||
| thumbnailSection | ||
| pokitNameSection | ||
| if !store.itemList.isEmpty { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
#51
📝작업 내용
스크린샷 (선택)
포킷추가포킷수정(포킷명과 썸네일을 입력받음)💬리뷰 요구사항(선택)
close #51