Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

프로젝트 구조 변경 #50

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Conversation

ShapeKim98
Copy link
Contributor

#️⃣연관된 이슈

#46

📝작업 내용

이번 PR에서 작업한 내용을 간략히 설명해주세요(이미지 첨부 가능)

  • 클린 아키텍처를 버리고 App에 Firebase를 바로 의존하는 구조로 변경하였습니다.

스크린샷 (선택)

graph

💬리뷰 요구사항(선택)

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

릴리즈에서는 모든 모듈을 정적 프레임워크/라이브러리로 관리하고 싶은데, 그렇게 하면 앱 크래시가 나는데 이유를 모르겠어요..

close #46

@ShapeKim98 ShapeKim98 requested review from ITlearning and stealmh July 23, 2024 06:00
@ShapeKim98 ShapeKim98 self-assigned this Jul 23, 2024
Copy link
Member

@stealmh stealmh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

페어프로그래밍 진행했습니다

@stealmh stealmh merged commit 53a7dc7 into develop Jul 23, 2024
@ShapeKim98 ShapeKim98 deleted the feature/#46-tuist-architecture branch July 27, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants