Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

카테고리 순서 변경 불가 버그 수정 #139

Merged
merged 1 commit into from
May 24, 2023
Merged

카테고리 순서 변경 불가 버그 수정 #139

merged 1 commit into from
May 24, 2023

Conversation

akalswl14
Copy link
Member

구현 내용

구현 요약

  • [PUT] /category/sequence 요청시, Request Body로 넘겨주는 CategoryDto에 sequence값을 변경된 순서값으로 넘겨줘 index out of error가 발생함
    • 기존 로직은, Request Body에 넘겨주는 CategoryDto에 넘겨주는 sequence 값이 기존의 값이며, 변경된 배열의 순서는 Request Body에 담긴 배열 내의 CategoryDto 순서를 바탕으로 순서를 조정하였음
    • 따라서, Request Body로 넘겨주는 CategoryDto에 sequence값을 변경된 순서값으로 받도록 처리함

관련 이슈

close #136

구현 내용

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@akalswl14 akalswl14 added the 버그 버그 수정 label May 24, 2023
@akalswl14 akalswl14 requested a review from le2sky May 24, 2023 04:27
@akalswl14 akalswl14 self-assigned this May 24, 2023
akalswl14
akalswl14 commented May 24, 2023
View reviewed changes
Copy link
Member Author

@akalswl14 akalswl14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@le2sky
코멘트 남겼으니 확인부탁드립니다!

@akalswl14 akalswl14 changed the title 🐛 bug: 카테고리 순서 변경 불가 버그 수정 카테고리 순서 변경 불가 버그 수정 May 24, 2023
@akalswl14 akalswl14 marked this pull request as ready for review May 24, 2023 04:33
@akalswl14 akalswl14 closed this May 24, 2023
@akalswl14 akalswl14 deleted the bug/136 branch May 24, 2023 08:16
@akalswl14 akalswl14 restored the bug/136 branch May 24, 2023 08:24
@akalswl14 akalswl14 reopened this May 24, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

le2sky
le2sky reviewed May 24, 2023
View reviewed changes
Copy link
Member

@le2sky le2sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드 확인했어요! LGTM입니다 👍👍 클라이언트에서 기존 시퀀스를 보낼 줄 알았는데, 그게 아녔군요! 원인 찾아내기 어려웠을 텐데 고생 많으셨어요 🙇‍♂️

src/main/java/com/yapp/artie/domain/archive/service/CategoryService.java Show resolved Hide resolved
@le2sky le2sky merged commit 77dd465 into develop May 24, 2023
@le2sky le2sky deleted the bug/136 branch May 24, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@le2sky le2sky le2sky left review comments

Assignees

@akalswl14 akalswl14

Labels
버그 버그 수정
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akalswl14 @le2sky