Skip to content

Commit

Permalink
[Python Misc] Revert change to print backtrace in server (grpc#34877)
Browse files Browse the repository at this point in the history
Fix: grpc#34853

In order to make debugging easier, we have begun printing backtraces in servers. However, this change has the unintended consequence of printing errors to stderr by default, which may not be expected by some users.

This PR reverts the change. We recommend that users set up a logging sink if they want to see errors. We will add this to our documentation later.

<!--

If you know who should review your pull request, please assign it to that
person, otherwise the pull request would get assigned randomly.

If your pull request is for a specific language, please add the appropriate
lang label.

-->

Closes grpc#34877

COPYBARA_INTEGRATE_REVIEW=grpc#34877 from XuanWang-Amos:revert_print_backtrace_change 8942308
PiperOrigin-RevId: 588885550
  • Loading branch information
XuanWang-Amos committed Jan 5, 2024
1 parent 612ba45 commit 08134b9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/python/grpcio/grpc/_server.py
Original file line number Diff line number Diff line change
Expand Up @@ -579,7 +579,7 @@ def _call_behavior(
exception.__traceback__,
)
)
traceback.print_exc()
traceback.print_exc()
_LOGGER.exception(details)
_abort(
state,
Expand Down

0 comments on commit 08134b9

Please sign in to comment.