The socket directories override from CLI is not necessary, because: #3281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Socket-activated Xpra proxy server listens on TCP port 14500,
and does not bind to any Unix domain socket via '--bind=none'.
* Non-socket-activated Xpra proxy server listens on TCP port 14500
and does bind on '/run/xpra/system' domain socket via
'--bind=/run/xpra/system'.
The negative side effect of restricting 'DotXpra.socket_details'
to search only in '/run/xpra' is that existing sockets in
'$XDG_RUNTIME_DIR/xpra' can not be found by 'make_authenticators',
so remote user can not re-attach to existing Xpra backend server
via proxy.
Signed-off-by: Vasyl Gello <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Socket-activated Xpra proxy server listens on TCP port 14500,
and does not bind to any Unix domain socket via
-bind=none.Non-socket-activated Xpra proxy server listens on TCP port 14500
and does bind on
/run/xpra/systemdomain socket via--bind=/run/xpra/system.The negative side effect of restricting
DotXpra.socket_detailsto search only in
/run/xprais that existing sockets in$XDG_RUNTIME_DIR/xpracan not be found bymake_authenticators,so remote user can not re-attach to existing Xpra backend server
via proxy.
Signed-off-by: Vasyl Gello [email protected]