Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trust some connections with unencrypted data #4436

Closed
totaam opened this issue Dec 8, 2024 · 1 comment
Closed

trust some connections with unencrypted data #4436

totaam opened this issue Dec 8, 2024 · 1 comment
Labels

Comments

@totaam
Copy link
Collaborator

totaam commented Dec 8, 2024

This check is hard-coding the socket types that can be trusted:

def is_sending_encrypted(self) -> bool:
return bool(self.cipher_out_name) or self._conn.socktype in ("ssl", "wss", "ssh")

But there should be a way to override this and trust specific connections when the user knows that the transport used is actually safe.
Example use-cases:

  • VMs running locally
  • VPN connections
  • connection to (local / DMZ) proxies that provide their own encryption
@totaam
Copy link
Collaborator Author

totaam commented Dec 8, 2024

Done in the commit above.

Example usage:

xpra attach "tcp://192.168.0.10:10000/?trusted=yes"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant