Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use the system provided xxHash library #3929

Closed
totaam opened this issue Jul 21, 2023 · 2 comments
Closed

use the system provided xxHash library #3929

totaam opened this issue Jul 21, 2023 · 2 comments
Labels
enhancement New feature or request packaging

Comments

@totaam
Copy link
Collaborator

totaam commented Jul 21, 2023

xxHash was bumped to version 0.8.2 in 893052d.
We should enable its xxh_x86dispatch.c.

Difficulty:
Compile this file with the default flags for your target.
Do not compile with flags like -mavx*, -march=native, or /arch:AVX*, there will be an error.
@totaam totaam added enhancement New feature or request packaging labels Jul 21, 2023
@totaam
Copy link
Collaborator Author

totaam commented Jul 24, 2023

It might also be a good time to stop bundling xxhash and use the library:

xxhash.x86_64 : Extremely fast hash algorithm
xxhash-devel.x86_64 : Extremely fast hash algorithm - development files
xxhash-libs.x86_64 : Extremely fast hash algorithm - library

totaam added a commit that referenced this issue Sep 3, 2023
@totaam
#3929 build against the system xxhash libs
eb86086
@totaam totaam changed the title enable xxHash dispatcher use the system provided xxHash library Sep 3, 2023
@totaam
Copy link
Collaborator Author

totaam commented Sep 3, 2023

Leave it to the OS to enable the correct build options for xxhash (dispatcher or not).

@totaam totaam closed this as completed Sep 3, 2023
totaam added a commit that referenced this issue Sep 3, 2023
@totaam
#3929 install xxhash for MS Windows builds
198f9e2
totaam added a commit that referenced this issue Sep 3, 2023
@totaam
#3929 use pkg-config to find xxhash lib
323586f
totaam added a commit to Xpra-org/gtk-osx-build that referenced this issue Sep 3, 2023
@totaam
add xxhash for Xpra-org/xpra#3929
9ffe8e4
totaam added a commit that referenced this issue Sep 3, 2023
@totaam
#3929 CI now needs it as well
098fdcd
@totaam totaam mentioned this issue Aug 4, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request packaging
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@totaam