Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

speedup argb cython module #3361

Closed
totaam opened this issue Nov 24, 2021 · 1 comment
Closed

speedup argb cython module #3361

totaam opened this issue Nov 24, 2021 · 1 comment
Labels
encoding enhancement New feature or request

Comments

@totaam
Copy link
Collaborator

totaam commented Nov 24, 2021 •
edited
Loading

Some codecs require an RGB input format different from the one we get from the X11 server.
ie: nvjpeg only takes RGB and BGR as input but XShm images are in BGRX format.
@totaam totaam added enhancement New feature or request encoding labels Nov 24, 2021
totaam added a commit that referenced this issue Nov 24, 2021
@totaam
#3361 read 32-bit at a time where possible
d4f39a4
totaam added a commit that referenced this issue Nov 24, 2021
@totaam
#3361 command line test scripts
853d596
@totaam
Copy link
Collaborator Author

totaam commented Nov 24, 2021 •
edited
Loading

The commit above makes a massive difference, for some conversions the performance is doubled!
On my test system, going from ~600 Megapixels/s to 1200!
(for others, Cython would generate awful C code and they have been left as they are)

This helps with #3337

@totaam totaam closed this as completed Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
encoding enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@totaam