Added 1 in 1 out support for new simplified testbench and updated additional designs #2065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
+41
to
+42
| int verify_passthrough_kernel(DATATYPE_IN1 *bufIn1, | ||
| DATATYPE_OUT *bufOut, int SIZE, int verbosity) { |
There was a problem hiding this comment.
[clang-format] reported by reviewdog 🐶
Suggested change
| int verify_passthrough_kernel(DATATYPE_IN1 *bufIn1, | |
| DATATYPE_OUT *bufOut, int SIZE, int verbosity) { | |
| int verify_passthrough_kernel(DATATYPE_IN1 *bufIn1, DATATYPE_OUT *bufOut, | |
| int SIZE, int verbosity) { |
Comment on lines
+71
to
+72
| int res = xrt_test_run<DATATYPE_IN1, DATATYPE_OUT, | ||
| initialize_bufIn1, |
There was a problem hiding this comment.
[clang-format] reported by reviewdog 🐶
Suggested change
| int res = xrt_test_run<DATATYPE_IN1, DATATYPE_OUT, | |
| initialize_bufIn1, | |
| int res = xrt_test_run<DATATYPE_IN1, DATATYPE_OUT, initialize_bufIn1, |
| @@ -44,6 +44,12 @@ struct args parse_args(int argc, const char *argv[]) { | |||
| return myargs; | |||
| } | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
[clang-format] reported by reviewdog 🐶
Suggested change
Comment on lines
+219
to
+220
| int xrt_test_run(int IN1_VOLUME, int OUT_VOLUME, | ||
| struct args myargs) { |
There was a problem hiding this comment.
[clang-format] reported by reviewdog 🐶
Suggested change
| int xrt_test_run(int IN1_VOLUME, int OUT_VOLUME, | |
| struct args myargs) { | |
| int xrt_test_run(int IN1_VOLUME, int OUT_VOLUME, struct args myargs) { |
| T3 *bufOut = bo_out.map<T3 *>(); | ||
|
|
||
| init_bufIn1(bufIn1, IN1_VOLUME); | ||
| init_bufOut(bufOut, OUT_VOLUME); // <<< what size do I pass it? reset with trace? |
There was a problem hiding this comment.
[clang-format] reported by reviewdog 🐶
Suggested change
| init_bufOut(bufOut, OUT_VOLUME); // <<< what size do I pass it? reset with trace? | |
| init_bufOut(bufOut, | |
| OUT_VOLUME); // <<< what size do I pass it? reset with trace? |
Comment on lines
+302
to
+303
| errors += | ||
| verify_results(bufIn1, bufOut, IN1_VOLUME, myargs.verbosity); |
There was a problem hiding this comment.
[clang-format] reported by reviewdog 🐶
Suggested change
| errors += | |
| verify_results(bufIn1, bufOut, IN1_VOLUME, myargs.verbosity); | |
| errors += verify_results(bufIn1, bufOut, IN1_VOLUME, myargs.verbosity); |
| @@ -83,20 +83,24 @@ def sequence(inTensor, outTensor, notUsed): | |||
|
|
|||
|
|
|||
| try: | |||
| if (len(sys.argv) < 4): | |||
There was a problem hiding this comment.
[black] reported by reviewdog 🐶
Suggested change
| if (len(sys.argv) < 4): | |
| if len(sys.argv) < 4: |
| print("Vector size must be a multiple of 64 and greater than or equal to 512") | ||
| in1_size = int(sys.argv[2]) | ||
| if in1_size % 64 != 0 or in1_size < 512: | ||
| print("In1 buffer size must be a multiple of 64 and greater than or equal to 512") |
There was a problem hiding this comment.
[black] reported by reviewdog 🐶
Suggested change
| print("In1 buffer size must be a multiple of 64 and greater than or equal to 512") | |
| print( | |
| "In1 buffer size must be a multiple of 64 and greater than or equal to 512" | |
| ) |
Coverage ReportCreated: 2025-02-22 06:40Click here for information about interpreting this report.
Generated by llvm-cov -- llvm version 18.1.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.