AIE Halt Plugin for VE2 #8808
AIE Halt Plugin for VE2 #8808
Conversation
…s for 4x4 design Signed-off-by: Ishita Ghosh <[email protected]>
Signed-off-by: Ishita Ghosh <[email protected]>
…ails. Eliminate AIE RT dependency as custom elf is used for now. Signed-off-by: Ishita Ghosh <[email protected]>
…with halt instructions Signed-off-by: Ishita Ghosh <[email protected]>
Signed-off-by: Ishita Ghosh <[email protected]>
Signed-off-by: Ishita Ghosh <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| namespace xdp { | ||
|
|
||
| class AIEHaltVE2Impl : public AIEHaltImpl |
There was a problem hiding this comment.
warning: class 'AIEHaltVE2Impl' defines a default destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator [cppcoreguidelines-special-member-functions]
class AIEHaltVE2Impl : public AIEHaltImpl
^| { | ||
|
|
||
| public : | ||
| AIEHaltVE2Impl(VPDatabase* dB); |
There was a problem hiding this comment.
warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [hicpp-explicit-conversions]
| AIEHaltVE2Impl(VPDatabase* dB); | |
| explicit AIEHaltVE2Impl(VPDatabase* dB); |
| public : | ||
| AIEHaltVE2Impl(VPDatabase* dB); | ||
|
|
||
| ~AIEHaltVE2Impl() = default; |
There was a problem hiding this comment.
warning: annotate this function with 'override' or (rarely) 'final' [hicpp-use-override]
| ~AIEHaltVE2Impl() = default; | |
| ~AIEHaltVE2Impl() override = default; |
|
|
||
| ~AIEHaltVE2Impl() = default; | ||
|
|
||
| virtual void updateDevice(void* hwCtxImpl); |
There was a problem hiding this comment.
warning: prefer using 'override' or (rarely) 'final' instead of 'virtual' [cppcoreguidelines-explicit-virtual-functions]
| virtual void updateDevice(void* hwCtxImpl); | |
| void updateDevice(void* hwCtxImpl) override; |
| ~AIEHaltVE2Impl() = default; | ||
|
|
||
| virtual void updateDevice(void* hwCtxImpl); | ||
| virtual void finishflushDevice(void* hwCtxImpl); |
There was a problem hiding this comment.
warning: prefer using 'override' or (rarely) 'final' instead of 'virtual' [cppcoreguidelines-explicit-virtual-functions]
| virtual void finishflushDevice(void* hwCtxImpl); | |
| void finishflushDevice(void* hwCtxImpl) override; |
Problem solved by the commit
Support AIE Halt Plugin for VE2.
The PR also contains some cleanup for ML Timeline Plugin on VE2.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
How problem was solved, alternative solutions (if any) and why they were rejected
Risks (if any) associated the changes in the commit
What has been tested and how, request additional testing if necessary
Build for VE2 and Unit tests on VE2 board
Documentation impact (if any)