Changes to use aie trace metadata section #8352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vinod Pangul <[email protected]>
Signed-off-by: Vinod Pangul <[email protected]>
Signed-off-by: Vinod Pangul <[email protected]>
stsoe
approved these changes
Aug 16, 2024
chvamshi-xilinx
approved these changes
Aug 16, 2024
jvillarre
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
Recently a new section
AIE_TRACE_METADATAhas been packaged to xclbin required for xdp profiling plugins.This change is to use this new section at runtime to configure the plugins.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
Enhancement
How problem was solved, alternative solutions (if any) and why they were rejected
Added new entry in xrt core to identify this section.
Risks (if any) associated the changes in the commit
Medium for changes in XRT Core.
This new metadata format has been already used on client. We have a safeguard to use AIE_METADATA if AIE_TRACE_METADATA isn't available.
What has been tested and how, request additional testing if necessary
Verified that xclbin query returns the metadata needed and profile / trace plugins works with no issues.
Verified that xclbinutil tool shows & dumps this new metadata and is matches with what is packaged in design directory.
Verified on edge VCK190
Documentation impact (if any)