Add DRC to xclbinutil for Linux file command utility compliance #8337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xvijaysri <[email protected]>
|
Can one of the admins verify this patch? |
Signed-off-by: xvijaysri <[email protected]>
stsoe
requested changes
Aug 8, 2024
xfreid
reviewed
Aug 8, 2024
xfreid
reviewed
Aug 8, 2024
Signed-off-by: xvijaysri <[email protected]>
xfreid
reviewed
Aug 9, 2024
src/runtime_src/tools/xclbinutil/unittests/FileCheck/FileCheck.py
Outdated
Show resolved
Hide resolved
xfreid
reviewed
Aug 9, 2024
src/runtime_src/tools/xclbinutil/unittests/FileCheck/FileCheck.py
Outdated
Show resolved
Hide resolved
xfreid
approved these changes
Aug 9, 2024
Signed-off-by: xvijaysri <[email protected]>
Signed-off-by: xvijaysri <[email protected]>
Signed-off-by: xvijaysri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to add a DRC to xclbinutil so the generated xclbin remains compliant with the expectations of the file utility (CR-1148239).
Specifically the following fields should always be populated for the file command to work:
struct axlf, m_header.m_length
struct axlf, m_header.m_timeStamp
struct axlf, m_header.m_platformVBNV
struct axlf, m_header.uuid
struct axlf, m_header.m_numSections
All these fields would be populated only when the xclbin contains atleast one section and platformVBNV information.
This feature is considered low risk as the DRC check happens only when the user specifies --file-check option in command line along with xclbin file.
Unit test has been added that verifies if the DRC check passes for valid xclbin file i.e., it contains the platformVBNV information and atleast one section.