Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starting Event trace from specific layer #8334

Merged
merged 4 commits into from
Aug 6, 2024

Conversation

jyothees99
Copy link
Collaborator

Problem solved by the commit

Overrun: While running an ML design, if there is any overrun of trace events in between, then there won't be any trace after the overrun. Instead of starting trace when the design starts, user can specify from which ML layer they want to start the trace. So that they can get the trace for layers which they were not able to before.
External Buffer size: For large ML designs, we need more space to store trace data. By only tracing range of layers, external buffer size for trace can be decreased.

How problem was solved, alternative solutions (if any) and why they were rejected

  1. A user event will be generated in shim tile (0,0) by controller after each layer end and start of the run.
  2. Performance counter at shim (0,0) is configured to count the above event.
  3. Through xrt.ini, user passes start layer.
  4. An event broadcast network is used to broadcast an event to all tiles when performance counter reaches the start layer.
  5. All the trace modules are configured to start when the broadcast event reaches them.

Risks (if any) associated the changes in the commit

No. Code will be executed only if user passes start_type=layer in xrt.ini

What has been tested and how, request additional testing if necessary

Tested resnet50 design on strix windows and partial resnet50 design on phoenix windows.

@gbuildx
Copy link
Collaborator

gbuildx commented Aug 5, 2024

Can one of the admins verify this patch?

@jyothees99 jyothees99 changed the title Event trace layer wise Starting Event trace from specific layer Aug 5, 2024
Copy link
Collaborator

@jvillarre jvillarre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved if the name of the utility function is updated to getPartitionNumColumnsClient

@jvillarre jvillarre merged commit cc44c36 into Xilinx:master Aug 6, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants