Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CR-1206429 xrt-smi output and help menu fixes #8297

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Conversation

rchane
Copy link
Collaborator

@rchane rchane commented Jul 18, 2024

Problem solved by the commit

https://jira.xilinx.com/browse/CR-1206429

Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered

  1. xrt-smi validate help menu showed --report instead of --run, now shows --run
  2. xrt-smi did not return from printing help menu (e.g. run xrt-smi), instead returning later when attempting to run non-existent subcmd
  3. Some small output fixes:
    Host Report: BIOS vendor -> BIOS Vendor, BIOS version -> BIOS Version, Devices present -> Device(s) Present
    Platform Report: Performance Mode -> Power Mode, fix colon spacing for Power field
    Validate: Performance Mode -> Power Mode

How problem was solved, alternative solutions (if any) and why they were rejected

Fixed to above.

Risks (if any) associated the changes in the commit

N/A

What has been tested and how, request additional testing if necessary

C:\Users\rchane\Desktop\xrt>xrt-smi validate --help

COMMAND: validate

DESCRIPTION: Validates the given device by executing the platform's validate executable.

USAGE: xrt-smi validate [--help] [-d arg] [-f arg] [-o arg] [-p arg] [-r arg] [--param arg]

OPTIONS:
  -d, --device       - The Bus:Device.Function (e.g., 0000:d8:00.0) device of interest
  -f, --format       - Report output format. Valid values are:
                         JSON        - Latest JSON schema
                         JSON-2020.2 - JSON 2020.2 schema
  -o, --output       - Direct the output to the given file
  --param            - Extended parameter for a given test. Format: <test-name>:<key>:<value>
  -p, --path         - Path to the directory containing validate xclbins
  --help             - Help to use this sub-command
  -r, --run          - Run a subset of the test suite. Valid options are:
                         all                  - All applicable validate tests will be executed
                                                (default)
                         cmd-chain-latency    - Run end-to-end latency test using command chaining
                         cmd-chain-throughput - Run end-to-end throughput test using command
                                                chaining
                         df-bw                - Run bandwidth test on data fabric
                         gemm                 - Measure the TOPS value of GEMM operations
                         latency              - Run end-to-end latency test
                         quick                - Only the first 4 tests will be executed
                         tct-all-col          - Measure average TCT processing time for all
                                                columns
                         tct-one-col          - Measure average TCT processing time for one column
                         throughput           - Run end-to-end throughput test

EXTENDED KEYS:
  dma                - block-size:<value> - Memory transfer size (bytes)


GLOBAL OPTIONS:
  --verbose          - Turn on verbosity
  --batch            - Enable batch mode (disables escape characters)
  --force            - When possible, force an operation

C:\Users\rchane\Desktop\xrt>xrt-smi examine
System Configuration
  OS Name              : Windows NT
  Release              : 26046
  Machine              : x86_64
  CPU Cores            : 16
  Memory               : 32109 MB
  Distribution         : Microsoft Windows 11 Enterprise Insider Preview
  Model                : BIRMANPLUS
  BIOS Vendor          : AMD
  BIOS Version         : VXB899825N

XRT
  Version              : 2.18.0
  Branch               : HEAD
  Hash                 : 9048adae9b544fe0b538e37f2abed605baf16961
  Hash Date            : 2024-07-17 16:56:46
  ipukmddrv            : 10.1.0.1
  NPU Firmware Version : 0.7.22.116

Device(s) Present
|BDF             ||Name  |
|----------------||------|
|[00c5:00:01.1]  ||NPU   |

C:\Users\rchane\Desktop\xrt>xrt-smi examine -r platform

---------------------
[00c5:00:01.1] : NPU
---------------------
Platform
  Name                   : NPU
  Power Mode             : Default

Clocks
  H Clock                : 1810 MHz
  MP-IPU Clock           : 1267 MHz

Power                    : 0.000 Watts

C:\Users\rchane\Desktop\xrt>xrt-smi validate
Validate Device           : [00c5:00:01.1]
    Platform              : NPU
    Power Mode            : Default
-------------------------------------------------------------------------------
Test 1 [00c5:00:01.1]     : latency
    Details               : Average latency: '129.7' us
    Test Status           : [PASSED]
-------------------------------------------------------------------------------
Test 2 [00c5:00:01.1]     : throughput
    Details               : Average throughput: '8992.5' ops
    Test Status           : [PASSED]
-------------------------------------------------------------------------------
Test 3 [00c5:00:01.1]     : cmd-chain-latency
    Details               : Average latency: '9.1' us
    Test Status           : [PASSED]
-------------------------------------------------------------------------------
Test 4 [00c5:00:01.1]     : cmd-chain-throughput
    Details               : Average throughput: '109179.1' ops
    Test Status           : [PASSED]
-------------------------------------------------------------------------------
Test 5 [00c5:00:01.1]     : df-bw
    Details               : Average bandwidth per shim DMA: '52.8' GB/s
    Test Status           : [PASSED]
-------------------------------------------------------------------------------
Test 6 [00c5:00:01.1]     : tct-one-col
    Details               : Average TCT throughput: '405538.0' TCT/s
    Test Status           : [PASSED]
-------------------------------------------------------------------------------
Test 7 [00c5:00:01.1]     : tct-all-col
    Details               : Average TCT throughput: '815730.6' TCT/s
    Test Status           : [PASSED]
-------------------------------------------------------------------------------
Test 8 [00c5:00:01.1]     : gemm
    Details               : Kernel name is 'DPU_1x4'
                            TOPS: '49.7'
    Test Status           : [PASSED]
-------------------------------------------------------------------------------
Validation completed. Please run the command '--verbose' option for more details

Documentation impact (if any)

N/A

@rchane rchane requested a review from stsoe July 18, 2024 20:40
@stsoe stsoe merged commit aaabbaa into Xilinx:master Jul 18, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants