-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Xiangyu/revise fm mesh #740
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… but third run ok again) for the stfb_sycl case. This does not happen for sycl using intel CPU as device, or the tbb using computing kernel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now all FVM cases use Vtu format, and Vtp format should be used only for surface Mesh.
Summary by Copilot:
This pull request involves significant refactoring and reorganization of the VTK I/O system for both 2D and 3D builds. The changes include removing old code, renaming files, and introducing new methods for handling VTK file writing.
The most important changes include:
Removal of Old Code:
src/for_2D_build/io_system/io_vtk_fvm_2d.cpp
andsrc/for_3D_build/io_system/io_vtk_fvm_3d.cpp
. [1] [2]Refactoring and Reorganization:
MeshFileHelpers
insrc/for_3D_build/bodies/mesh_helper_3d.cpp
andsrc/shared/bodies/complex_bodies/mesh_helper.h
. [1] [2]io_vtk_fvm.h
and addedio_vtk_mesh.h
insrc/shared/io_system/io_all.h
.Introduction of New Methods:
src/shared/io_system/io_vtk_mesh.cpp
under the new classesBodyStatesRecordingToMeshVtp
andBodyStatesRecordingToMeshVtu
. These methods includeFileHeader
,FileNodeCoordinates
,FileInformationKey
,FileCellConnectivity
,FileOffsets
, andFileTypeOfCell
.Code Cleanup:
src/shared/io_system/io_vtk_fvm.cpp
.