Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xiangyu/revise fm mesh #740

Closed
wants to merge 20 commits into from
Closed

Xiangyu/revise fm mesh #740

wants to merge 20 commits into from

Conversation

Xiangyu-Hu
Copy link
Owner

now all FVM cases use Vtu format, and Vtp format should be used only for surface Mesh.

Summary by Copilot:
This pull request involves significant refactoring and reorganization of the VTK I/O system for both 2D and 3D builds. The changes include removing old code, renaming files, and introducing new methods for handling VTK file writing.

The most important changes include:

Removal of Old Code:

  • Removed methods related to VTK file writing from src/for_2D_build/io_system/io_vtk_fvm_2d.cpp and src/for_3D_build/io_system/io_vtk_fvm_3d.cpp. [1] [2]

Refactoring and Reorganization:

  • Deleted VTK file writing methods from MeshFileHelpers in src/for_3D_build/bodies/mesh_helper_3d.cpp and src/shared/bodies/complex_bodies/mesh_helper.h. [1] [2]
  • Removed io_vtk_fvm.h and added io_vtk_mesh.h in src/shared/io_system/io_all.h.

Introduction of New Methods:

  • Added new methods for VTK file writing in src/shared/io_system/io_vtk_mesh.cpp under the new classes BodyStatesRecordingToMeshVtp and BodyStatesRecordingToMeshVtu. These methods include FileHeader, FileNodeCoordinates, FileInformationKey, FileCellConnectivity, FileOffsets, and FileTypeOfCell.

Code Cleanup:

  • Removed old VTK I/O related code from src/shared/io_system/io_vtk_fvm.cpp.

@Xiangyu-Hu Xiangyu-Hu closed this Feb 6, 2025
@Xiangyu-Hu Xiangyu-Hu reopened this Feb 8, 2025
@Xiangyu-Hu Xiangyu-Hu added the sycl_ck for heterogenous parallelism label Feb 9, 2025
@Xiangyu-Hu Xiangyu-Hu closed this Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sycl_ck for heterogenous parallelism
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant