Log mutations and present PR details to user #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bittrance
force-pushed
the
basic-logging
branch
6 times, most recently
from
d82be82 to
1488ba0
Compare
added 3 commits
November 26, 2021 00:07
Signed-off-by: Anders Qvist <[email protected]>
Signed-off-by: Anders Qvist <[email protected]>
bittrance
force-pushed
the
basic-logging
branch
from
1488ba0 to
2378a01
Compare
Signed-off-by: Anders Qvist <[email protected]>
bittrance
force-pushed
the
basic-logging
branch
from
2378a01 to
27e7f13
Compare
bittrance
changed the title
simongottschlag
approved these changes
Nov 26, 2021
There was a problem hiding this comment.
Great job @bittrance! Left a few comments but mostly questions. 😊
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gitops-promotion is written in the style of a cli tool. As such, it should not spam unnecessarily. However, when running in a pipeline you sometimes want to look at old runs where it is not always obvious e.g. what commits were actually visible at the time, we need some logging. This PR introduces a bit of daemon-style logging in the hope that issues can be debugged more easily. It also improves on the central messages from new and promote commands to say what PR was created and what its branch is called. This is generally useful, but is particularly pertinent if we merge #136 which may create more than one PR which differ only in the container sha.