Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I'd like you to implement my changes and allow me to post them to workshop. #96

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Conversation

ghost
Copy link

@ghost ghost commented May 11, 2014

I have many new plugins and fixes.

:)

GreyGeist added 18 commits May 11, 2014 15:45
Allows for player model restriction, using prefix "&"
The actual tab.  Requires built in player manager.  Allows you to modify
permissions for playermodels.
Fixes issues, allows for TTT compatibility, and adds playermodel
restriction.
Reverts god.  See !sgod / "Self God"
Replacement for the new version of godmode.  Makes it so that users can
only god themselves when using !sgod, and then you can give higher ranks
the normal god.
See title.
Allows respawning players in TTT, plus some fixes.
You want this.  It's amazingly useful so that you don't have to
continually teleport users.
May have a few bugs, but works well for the most part.  Includes
!friends to let users share props, and convars to configure.
Another way to control players / punish them.  If you !nospawn a player,
they'll be slain on spawn.
So you can spy on those darn guests!
Includes !votemap too
Fun punishment
ESP + No Recoil.
Needs work, but fully functional and easy to use already.
Since I forgot to include the plugin in the map tab commit.
Includes a bunch of different files.  Most aren't even changed, it's just to placate GIT.  Includes:
AI Disable
Drug
Earbleed
Gravity Control
Monitor throwing
Mapcycle control
DarkRP money
Nolag (broken, supposed to freeze all props)
Permamute
Player resize
Spawn protection
Thirdperson (expirimental / buggy)
Fixes VON
@ghost
Copy link
Author

ghost commented May 12, 2014

Seems to be really good !
Hope it will be implemented, i'll try it soon.

@MuteTM
Copy link
Contributor

MuteTM commented May 13, 2014

Great additions. Do you know if it's possible to restrict the command list to only show what a player has access to?

@ghost
Copy link
Author

ghost commented May 13, 2014

@MuteTM

I should be able to add that in. If you want to do it, it should be in either sh_ or sv_commands. At work right now and can't check. Should go along the lines of

if ply:EV_HasPrivelage( ) then

end

@MuteTM
Copy link
Contributor

MuteTM commented May 14, 2014

Thanks for the tip, I managed to implement it. I'll leave the official implementation to those who can write clean code.

Other notes:

  • Hax still uses functions with Train in them - C&P'd from trainfuck?
  • Money command doesn't check if the gamemode is DarkRP
  • God/Self-God permissions could simply be done how the noclip plugin does them (one perm for self, one perm for others) instead of a different command, AFAIK
  • Norecoil is in sh_spawnprotection.lua - is this intentional?
  • Why change the location of the MOTD file? This breaks compatibility when a person updates evolve

@ghost
Copy link
Author

ghost commented May 14, 2014

Why don't you go ahead and send me the code? I can clean it up and
implement it faster than writing from scratch.

On 5/13/2014 9:11 PM, MuteTM wrote:

Thanks for the tip, I managed to implement it. I'll leave the official
implementation to those who can write clean code.


Reply to this email directly or view it on GitHub
#96 (comment).

@JakeyCakey
Copy link

Yes! i want this implented alot of commands seem very usefull!

@EntranceJew
Copy link

I definitely love your additions, although for whatever reason when I spawn the evolve:Notify() message has some garbage in it.
I called SPOnSpawn(myself) in the server context and it played the message fine. Any other time, though, it comes out with "�l����-,�L�$F� ��" taped to the backend of the message. It doesn't happen when I run the message by itself. (Emphasis mine while trying to test for its cause.)
Garbled Text

It happens no matter what, but I believe it has to do with the code on ev_framework.lua#77 due to how it is working with bits / networking the data. I've singled it out to having FAdmin enabled in DarkRP's disabled defaults, which is unfortunate considering how much DarkRP leans on FAdmin. Unfortunately I don't know enough about anything beyond that to be able to offer further solutions.

@Xandaros Xandaros force-pushed the master branch 3 times, most recently from 3d3cda7 to f3716f9 Compare September 29, 2014 01:39
@Xandaros Xandaros force-pushed the master branch 2 times, most recently from b0d68d0 to c54cca4 Compare June 29, 2015 18:15
@thegrb93
Copy link

@EntranceJew One of the plugins is passing something that isn't a color or string to evolve:Notify.

Copy link

@Jcdiem Jcdiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 7 of "Map tab + Advert3" should contain an end comment, the whole code is commented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants