Make the change non-breaking

XRPLF · Jul 18, 2023 · 9d06e03 · 9d06e03
1 parent a8d3a93
commit 9d06e03
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/packages/ripple-keypairs/HISTORY.md b/packages/ripple-keypairs/HISTORY.md
@@ -2,6 +2,9 @@
 
 ## Unreleased
 
+### Breaking
+- Fixed `deriveKeypair` ignoring the explicitly set `algorithm` for decoding the seed
+
 ## 1.3.0 (2023-06-13)
 ### Added
 * Adds support for npm v9

diff --git a/packages/xrpl/src/Wallet/index.ts b/packages/xrpl/src/Wallet/index.ts
@@ -324,9 +324,9 @@ export class Wallet {
     seed: string,
     opts: { masterAddress?: string; algorithm?: ECDSA } = {},
   ): Wallet {
-    const { publicKey, privateKey } = deriveKeypair(seed, {
-      algorithm: opts.algorithm ?? DEFAULT_ALGORITHM,
-    })
+    // TODO: Re-add { algorithm: opts.algorithm ?? DEFAULT_ALGORITHM } as an optional parameter
+    // To deriveKeypair as part of the next breaking version change to actually have an ed25519 default.
+    const { publicKey, privateKey } = deriveKeypair(seed)
     return new Wallet(publicKey, privateKey, {
       seed,
       masterAddress: opts.masterAddress,