Skip to content

use support list instead of prohibit list

Codecov / codecov/project succeeded Feb 20, 2025 in 1s

78.2% (target 60.0%)

View this Pull Request on Codecov

78.2% (target 60.0%)

Details

Codecov Report

Attention: Patch coverage is 97.71310% with 11 lines in your changes missing coverage. Please review.

Project coverage is 78.2%. Comparing base (43e1d44) to head (65c41fe).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
src/xrpld/app/tx/detail/Transactor.cpp 96.4% 4 Missing ⚠️
src/libxrpl/protocol/Indexes.cpp 60.0% 2 Missing ⚠️
src/xrpld/app/tx/detail/SetAccount.cpp 92.6% 2 Missing ⚠️
src/libxrpl/protocol/Permissions.cpp 97.2% 1 Missing ⚠️
src/xrpld/app/ledger/detail/LedgerToJson.cpp 0.0% 1 Missing ⚠️
src/xrpld/app/tx/detail/applySteps.cpp 95.7% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #5164     +/-   ##
=========================================
+ Coverage     77.9%   78.2%   +0.4%     
=========================================
  Files          791     794      +3     
  Lines        68007   68070     +63     
  Branches      8349    8188    -161     
=========================================
+ Hits         52963   53264    +301     
+ Misses       15044   14806    -238     
Files with missing lines Coverage Δ
include/xrpl/protocol/Feature.h 100.0% <ø> (ø)
include/xrpl/protocol/Indexes.h 100.0% <ø> (ø)
include/xrpl/protocol/STTx.h 100.0% <ø> (ø)
include/xrpl/protocol/STTxDelegated.h 100.0% <100.0%> (ø)
include/xrpl/protocol/detail/ledger_entries.macro 100.0% <100.0%> (ø)
include/xrpl/protocol/detail/transactions.macro 100.0% <100.0%> (ø)
src/libxrpl/protocol/InnerObjectFormats.cpp 100.0% <100.0%> (ø)
src/libxrpl/protocol/STParsedJSON.cpp 70.2% <100.0%> (+1.0%) ⬆️
src/libxrpl/protocol/STTx.cpp 87.4% <100.0%> (+0.6%) ⬆️
src/libxrpl/protocol/TxFormats.cpp 100.0% <ø> (ø)
... and 40 more

... and 29 files with indirect coverage changes

Impacted file tree graph