Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GRPCServer.cpp #5280

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Update GRPCServer.cpp #5280

merged 1 commit into from
Feb 10, 2025

Conversation

donovanhide
Copy link
Contributor

Omit superfluous setCurrentThreadName call.

High Level Overview of Change

Previous revert added back in two thread names.
ce570c1#diff-a5992bc868207dd320a19952bb4f5ffa326fd2581dd016fcb86afbeca07b7e93R695-R697

Context of Change

Type of Change

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

Omit superfluous setCurrentThreadName call.
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.1%. Comparing base (0968cdf) to head (c2dba2f).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #5280     +/-   ##
=========================================
- Coverage     78.1%   78.1%   -0.0%     
=========================================
  Files          790     790             
  Lines        67623   67622      -1     
  Branches      8163    8163             
=========================================
- Hits         52846   52844      -2     
- Misses       14777   14778      +1     
Files with missing lines Coverage Δ
src/xrpld/app/main/GRPCServer.cpp 44.2% <ø> (-0.2%) ⬇️

... and 2 files with indirect coverage changes

Impacted file tree graph

@bthomee bthomee added the Trivial Simple change with minimal effect, or already tested. Only needs one approval. label Feb 10, 2025
@bthomee
Copy link
Collaborator

bthomee commented Feb 10, 2025

@donovanhide To consistently follow the contributing process, can you please apply the "Ready to merge" label when this PR can be merged?

@donovanhide
Copy link
Contributor Author

Hi @bthomee Not sure I have permissions to add a label to this PR, unless I am missing some github magic?

@bthomee
Copy link
Collaborator

bthomee commented Feb 10, 2025

Hi @bthomee Not sure I have permissions to add a label to this PR, unless I am missing some github magic?

Ah true. In that case just commenting it's ok to have this PR merged is sufficient. Apologies for making you jump through a hoop.

@donovanhide
Copy link
Contributor Author

This PR is ready to merge!

@bthomee bthomee merged commit 8103459 into XRPLF:develop Feb 10, 2025
22 checks passed
@bthomee bthomee added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. Trivial Simple change with minimal effect, or already tested. Only needs one approval.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants