-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update secp256k1 library to version 0.6.0 #5254
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5254 +/- ##
=========================================
- Coverage 78.0% 78.0% -0.0%
=========================================
Files 789 789
Lines 67007 67007
Branches 8110 8108 -2
=========================================
- Hits 52274 52273 -1
- Misses 14733 14734 +1 |
@legleux was updating the library only a matter of removing all the old files and copying in the new ones, or did you have to massage one or more of them to get it to compile? While this change may have been a small chore to create, I think as "type of change" it should be modified to something else, since the binary is definitely affected by this PR. |
Agree. I renamed the PR. |
If Michael changes it in the description tomorrow as well, and confirms that this is the latest code without any changes, I'm good to approve. We'll need to run it through an extended testing cycle before including into 2.4.0 though. |
I did the check myself and confirm that dropping in v0.6.0 of secp256k1 matches this PR. |
High Level Overview of Change
Updates secp256k1 to
0.6.0
.Type of Change
.gitignore
, formatting, dropping support for older tooling)Test Plan
No discrepancies in unit tests were observed.
Future Tasks
This library should be integrated with CMake or Conan for easier maintenance.