Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MPTIssue to STIssue #5200

Merged
merged 13 commits into from
Dec 16, 2024

Merge branch 'develop' into feature/mpt-stissue

6544945
Select commit
Loading
Failed to load commit list.
Merged

Add MPTIssue to STIssue #5200

Merge branch 'develop' into feature/mpt-stissue
6544945
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 8, 2024 in 0s

77.8% (target 60.0%)

View this Pull Request on Codecov

77.8% (target 60.0%)

Details

Codecov Report

Attention: Patch coverage is 90.58824% with 8 lines in your changes missing coverage. Please review.

Project coverage is 77.8%. Comparing base (ea1fffe) to head (6544945).

Files with missing lines Patch % Lines
include/xrpl/protocol/STIssue.h 72.7% 3 Missing ⚠️
src/libxrpl/protocol/STIssue.cpp 91.4% 3 Missing ⚠️
src/xrpld/app/ledger/OrderBookDB.cpp 0.0% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #5200     +/-   ##
=========================================
- Coverage     77.9%   77.8%   -0.0%     
=========================================
  Files          783     782      -1     
  Lines        66677   66705     +28     
  Branches      8108    8126     +18     
=========================================
+ Hits         51921   51926      +5     
- Misses       14756   14779     +23     
Files with missing lines Coverage Δ
include/xrpl/protocol/Asset.h 95.0% <ø> (ø)
include/xrpl/protocol/Indexes.h 100.0% <ø> (ø)
include/xrpl/protocol/SOTemplate.h 96.8% <ø> (ø)
include/xrpl/protocol/STAmount.h 95.1% <ø> (ø)
include/xrpl/protocol/STXChainBridge.h 97.7% <100.0%> (ø)
src/libxrpl/protocol/Indexes.cpp 98.0% <100.0%> (+<0.1%) ⬆️
src/libxrpl/protocol/STTx.cpp 86.9% <100.0%> (+0.1%) ⬆️
src/xrpld/app/misc/detail/AMMUtils.cpp 99.4% <100.0%> (ø)
src/xrpld/app/tx/detail/AMMBid.cpp 90.5% <100.0%> (+0.1%) ⬆️
src/xrpld/app/tx/detail/AMMClawback.cpp 100.0% <100.0%> (ø)
... and 8 more

... and 11 files with indirect coverage changes

Impacted file tree graph