-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI unit tests #5196
Fix CI unit tests #5196
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5196 +/- ##
=======================================
Coverage 78.0% 78.0%
=======================================
Files 789 789
Lines 67007 67060 +53
Branches 8107 8109 +2
=======================================
+ Hits 52278 52321 +43
- Misses 14729 14739 +10
|
e6e8628
to
6799369
Compare
8332099
to
b6c13b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an elegant solution to rely on the system for dynamic port resolution.
I'm happy to approve this PR after a minor change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I started this review, but I didn't post it, and I'm not sure if I finished. Consider it a partial review.
It is not considered finished until approved, feel free to make breaks among your reviews. |
4918210
to
05b1f13
Compare
37982f2
to
3acdb64
Compare
8076e5d
to
225aa8a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like all my concerns have been addressed. Really looking forward to getting those CI jobs reliable again.
Two things:
- When you're updating from
develop
on a non-draft PR, please merge instead of rebasing. Using the "Show changes since your last review" doesn't work if you remerge, which makes it unnecessarily difficult to find updates. - Please don't resolve comments that I (and others?) leave in reviews, unless Github does it automatically (i.e. through the "Accept Suggestion" button). Again, it makes it a lot easier for me to follow up on my previous feedback when it may have been long enough that I don't remember precisely what I said, or where I said it.
After some numbers of open conversations GH going crazy and makes review impossible. It will randomly drop you to some another comment when you just reading something. When you scroll - it will shows you some random previous comments. When you reply it can redirect you replying to another comment. It became slow and unresponsive. (I observe this on different machines, OS and browsers, it is not my cache) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All comments addressed. LGTM now.
Weeeeeird. |
- Add retries for rpc client - Add dynamic port allocation for rpc servers
- Add retries for rpc client - Add dynamic port allocation for rpc servers
High Level Overview of Change
MACOS unit tests fix
Context of Change
Add retries to Env RPC requests to fix Macos disconnects during CI testing.
RPC server use ip ports assigned by operating system automatically (instead of hard-coded) when unit tests run.
Type of Change
API Impact