Securely erase memory & reduce public API #2224
Conversation
|
Here's one more spot that needs treatment: https://github.com/ripple/rippled/blob/develop/src/ripple/protocol/Serializer.h#L201 |
| @@ -199,6 +210,8 @@ generateSecretKey (KeyType type, Seed const& seed) | |||
|
|
|||
| if (type == KeyType::secp256k1) | |||
| { | |||
| // FIXME: Avoid copying the seed into a uint128 key only to have | |||
| // generateRootDeterministicPrivateKey copy out of it. | |||
There was a problem hiding this comment.
I probably don't understand all the nuances of the data - why don't we need to secure_erase the upk below?
There was a problem hiding this comment.
We'd need to massage things a bit to do it, but it's possible. Perhaps in the interest of thoroughness we should, even if it's a bit of extra work.
As I've marked elsewhere in the file, ideally we should change generateRootDeterministicPrivateKey to just take a Slice and not a uint128, and have it return a SecretKey directly.
Codecov Report
@@ Coverage Diff @@
## develop #2224 +/- ##
===========================================
- Coverage 70.07% 70.06% -0.01%
===========================================
Files 689 689
Lines 50730 50734 +4
===========================================
- Hits 35550 35549 -1
- Misses 15180 15185 +5
Continue to review full report at Codecov.
|
|
👍 |
|
Merged as 39f9135 |
nbougalis
added
the
Ready to merge
No description provided.