Switch from Carbon to Cocoa #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the comment says: In Compatibility mode (used by including gl.h instead of gl3.h), OS X only supports OpenGL 2 with some extensions. VAOs, which are an OpenGL 3 feature, are not available under their OpenGL 3 name. Instead they are exposed through an Apple-specific extension that works identically in all respects that matter. With this, it is possible to build and run the program without any trouble.
The Microseconds function is a leftover from the days of Carbon and deprecated since 10.8.
Yes, that does amount to pretty much a rewrite of the main.cpp. Don’t worry, it’s not that long. It also got renamed to main.mm because it’s an Objective-C++ file now. There are still a few rough edges, since I didn’t want to add a nib to any of this. Among other things, the display link probably starts a tiny bit too early, resulting in gameplay noises being heard before the game is actually visible. Resizing may leave white flashes; not quite sure what that’s about but they are brief. Finally, no menus of any kind. At least a system and window menu would be necessary (to support Cmd+Q).
The OS X code did not create a main menu. While it arguably doesn’t really need one, it’s considered impolite to forgo it on this platform, especially since all standard key commands interact with the menu bar (they quickly highlight the menu item that has the actual user-selectable command to provide some feedback). With this menu added, the Command+Q shortcut to quit the application now also works.
I’m not sure what to actually return here anyway, but apparently this symbol does not always exist.
Because it’s nicer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Carbon API was unofficially retired in 2007 (meaning it was not ported to 64 bit at the time), and officially deprecated in 2012. There is no excuse for an app written in 2016 to still use it.
This commit switches the code to use the Cocoa API instead. This amounts pretty much to a full rewrite of the main.cpp file since Cocoa has rather particular structure requirements. No game-specific parts were touched, however.
This pull request includes all the changes from pull request #17, so if you decide to accept this one then you can just close the other.