Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse communication object numbers of modules from allocators #362

Merged
merged 2 commits into from
Feb 11, 2024

Conversation

farmio
Copy link
Member

@farmio farmio commented Feb 11, 2024

  • Parse Allocators and ModuleDef argument Allocates
  • Move data merging from xml loader to dataclass method
  • Parse communication object numbers from allocators (as fallback if not set as ObjNumberBase argument value)

fixes #361

Copy link

codecov bot commented Feb 11, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (f3dea8a) 97.51% compared to head (d53ba88) 97.34%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #362      +/-   ##
==========================================
- Coverage   97.51%   97.34%   -0.18%     
==========================================
  Files          22       22              
  Lines        1087     1129      +42     
==========================================
+ Hits         1060     1099      +39     
- Misses         27       30       +3     
Files Coverage Δ
xknxproject/loader/application_program_loader.py 100.00% <100.00%> (+1.12%) ⬆️
xknxproject/models/__init__.py 100.00% <ø> (ø)
xknxproject/models/models.py 97.56% <95.91%> (-0.35%) ⬇️
xknxproject/xml/parser.py 93.33% <71.42%> (-1.45%) ⬇️

@farmio farmio merged commit 5c14dba into main Feb 11, 2024
5 of 7 checks passed
@farmio farmio deleted the comobject-numbers-module-allocator branch February 11, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ValueError: invalid literal for int() with base 10: 'L-1'
1 participant