Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct typo in add_to_z #630

Merged
merged 5 commits into from
Oct 21, 2017
Merged

correct typo in add_to_z #630

merged 5 commits into from
Oct 21, 2017

Conversation

pietrodigangi
Copy link
Contributor

correct typo in add_to_z assigned value.
It was add_to_z = (2.15 + 0.25) * cm -> correct is add_to_z = (2.15 + 0.025) * cm

correct typo in `add_to_z` assigned value. It was `add_to_z = (2.15 + 0.25) * cm` -> correct is `add_to_z = (2.15 + 0.025) * cm`
@feigaodm
Copy link
Member

For Xe100 the distance between gate and liquid level is 2.5mm. If we want to set gate to 0, we need 2.5 mm instead of 10 times smaller

@feigaodm feigaodm closed this Oct 19, 2017
@feigaodm
Copy link
Member

Maybe modify the one in Xe1T.ini file?

@feigaodm feigaodm reopened this Oct 19, 2017
@pietrodigangi
Copy link
Contributor Author

@feigaodm there was a misunderstanding with Jelle on gitter chat about that value (the typo is actually in the comment above)

@pietrodigangi
Copy link
Contributor Author

@feigaodm for XENON1T, has this z offset to be the same with impose in the Geant4 code to have the gate at 0? I'm not sure how the value in the Xe1T.ini relates to that one in G4

@JelleAalbers
Copy link
Contributor

Yes, Pietro spotted the inconsistency between comment and config, and I agreed it was a typo. However it's the comment that was incorrect while the config was ok. Should be fixed now.

@feigaodm
Copy link
Member

@JelleAalbers Should we change the one in XENON1T.ini to 0? You commented there that we should change it when G4 geometry is updated, and I think it happended long time ago.

@JelleAalbers
Copy link
Contributor

Yes, if the MC files now output positions in the common coordinate system, we can change that setting to 0, and remove the override in https://github.com/XENON1T/pax/blob/master/pax/config/SimulationMCInput.ini.

@feigaodm feigaodm merged commit 89a6cb5 into master Oct 21, 2017
@feigaodm feigaodm deleted the zoffset_typo branch October 21, 2017 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants