Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pax bug for very rare event #601

Merged
merged 4 commits into from
Sep 5, 2017
Merged

fix pax bug for very rare event #601

merged 4 commits into from
Sep 5, 2017

Conversation

feigaodm
Copy link
Member

@feigaodm feigaodm commented Aug 22, 2017

This PR tries to fix a bug reported by @ershockley when processing Rn220 calibration data with pax_v6.8.0. This bug is due to de-saturation plugin as this event has very wired saturation. Since not a lot channel are detecting signals during saturation, we should skip this event for de-saturation correction. This will fix issue (#599).

Waveform of this events is here.
stupid_waveform

@feigaodm feigaodm requested a review from pdeperio August 23, 2017 19:20
@feigaodm feigaodm requested a review from sanderbreur August 28, 2017 21:33
@sanderbreur
Copy link
Contributor

After checking it I think we are adding a needed check, but losing another needed check. Because iether the pulse itself or the sumw can have not enough samples. So I would keep this change, but add the deleted part back into the code. (so do it both for w and for sumw)

This should be added back:

  •        if len(w[reference_slice][w[reference_slice] > 1]) < self.config['reference_region_samples_treshold']:
    
  •            # the pulse is saturated, but there are not enough reference samples to get a good ratio
    
  •            # This actually distinguished between S1 and S2 and will only correct S2 signals
    
  •            continue
    

@feigaodm
Copy link
Member Author

feigaodm commented Sep 5, 2017

Thanks @sanderbreur , just added it back and merged the PR.

@feigaodm feigaodm merged commit 896b45e into master Sep 5, 2017
@feigaodm feigaodm deleted the pulse_desaturation_bug branch September 5, 2017 22:22
@sanderbreur
Copy link
Contributor

sanderbreur commented Sep 6, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants