Fix two bugs in new S1 AFT and pattern likelihood calculations #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for S1 likelihood calculations
0.2 is actually less than 0.16
|
Fine but prefer we test that updates don't break things before merging them. These variables now useless int the production we just did. |
pdeperio
pushed a commit
that referenced
this pull request
Dec 25, 2017
* Added posrec treemaker * Updates to posrec treemaker * Bug fixes * placeholder for tensorflow based pos_reconstruction * minor style issue * working version * lint fixes * Update posrec.py (#177) * Properly declare size of array * ignor bad pattern with hits * Added s1patternfit for bottom. Also split files into ini options * Fix S1 bottom pattern, docs, and lint (#180) * Fix S1 bottom pattern, docs, and lint * Fix oops * Increment version * Fixed some bugs and made it run * Update posrec.py add s1 area fraction near injection points near Rn220 source for anomalous leakage studies. Details can be seen in the following note. https://xe1t-wiki.lngs.infn.it/doku.php?id=xenon:xenon1t:analysis:sciencerun1:anomalous_background#can_we_remove_leakage_events_by_tightening_some_cuts * Update posrec.py * Update posrec.py * Update posrec.py * Address some of Chris' comments and lint fixes * Update NN files according to XENON1T/pax#650 * NN file switching depending on SR (#181) * Add capability to switch NN files for SR and more metadata and logging and lint fixes * More comments * Fix two bugs in new S1 AFT and pattern likelihood calculations (#183) * Fix bugs in event indexing and PMT selection for S1 likelihood calculations * Increment version * Fix version oops 0.2 is actually less than 0.16 * Add SR dependent bad PMT list (#184) * Pull corrections logic out of minitree maker (#185) * Added new corrections handler class * Made it work * Made posrec treemaker work with new class too * Revert version bump * Oops. Moved instead of git moved. * Implement in CorrectedDoubleS1Scatter and lint fixes * Add 3D FDC for TFNN in SR1 See details here: XENON1T/pax#655 * Add 3D FDC for TFNN in SR1 See details here: XENON1T/pax#655 * Update version number Forgot again... * fix bug Name should be 'event_data' instead of 'result'... * fix bugs * fix bugs 2 * Update posrec.py * Update posrec.py adding additional s1 width variables for AC events rejection * Update posrec.py * Add 3D FDC for TFNN in SR0 * More S1 AFT variables (#188) * Store additional AFT var using area instead of hits and AFT probability from map * Fix variable name * Store binomial probability instead of aft * Remove S1 width variables Moved to Extended minitree in #190 * sort the tensorflow files name * Update posrec.py * Make bad PMT list read-in work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Event index
iwas overwritten by a loop index over PMTs, socompute_gofands1_aft_map.get_valuewere always using the position of event number 247. Now fixed by using more explicit variable names.The argument
pmt_selectionincompute_gofshould be an array of booleans of sizeapc[self.tpc_channels]. Not sure if what's done inBuildInteractions.pyis correct, but here it was crashing atsince
pmts_bottomis no longer the full PMT array after removingconfused_s1_channels. Now I just explicitly keep a full PMT arrayis_pmt_in, similarly toTopPatternFit.pyto keep track of which PMTs to include in the likelihood.@requested reviewers, please double check this implementation and implications.