Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.5.1 #222

Merged
merged 1 commit into from
Jan 14, 2023
Merged

Release 2.5.1 #222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "xprofiler",
"version": "2.5.0",
"version": "2.5.1",
"description": "node.js addon to output runtime logs",
"bin": {
"xprofctl": "bin/xprofctl"
Expand All @@ -25,8 +25,8 @@
"lint": "npm run format && eslint --fix *.js \"test/**/*.js\" lib/*.js patch/*.js bin/xprofctl scripts/**/*.js",
"test": "mocha -t 0 -R spec test/*.test.js test/patch/*.test.js",
"test-single": "mocha -t 0 -R spec",
"cov": "nyc --reporter=html --reporter=text --reporter=lcov mocha -R spec test/*.test.js test/patch/*.test.js --timeout 0",
"cov-single": "nyc --reporter=html --reporter=text --reporter=lcov mocha --timeout 0 -R spec",
"cov": "nyc --reporter=html --reporter=text --reporter=lcov mocha -R spec test/*.test.js test/patch/*.test.js --timeout 60000",
"cov-single": "nyc --reporter=html --reporter=text --reporter=lcov mocha --timeout 60000 -R spec",
"codecov": "codecov || echo 'warning: ignoring codecov failure'",
"ci": "npm run lint && npm run build && npm run cov && npm run codecov",
"dep": "npm run build && npm run cov",
Expand Down
1 change: 1 addition & 0 deletions test/fixtures/cases/command.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,6 +399,7 @@ exports = module.exports = function (logdir) {
},
{
platform: 'linux',
arch: 'x64',
cmd: 'generate_coredump',
profileRules: checkCoreDump,
xctlRules(data) {
Expand Down
1 change: 1 addition & 0 deletions test/fixtures/cases/hooks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ exports = module.exports = function () {
},
{
platform: 'linux',
arch: 'x64',
title: 'fatal error hook is valid',
subTitle: 'x-fatal-error.core is created when fatal error occured.',
jspath: exitFatalErrorScriptPath,
Expand Down
6 changes: 5 additions & 1 deletion test/fixtures/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,11 @@ exports.filterTestCaseByPlatform = function filterTestCaseByPlatform(list) {
return list;
}

return list.filter(item => !item.platform || item.platform === os.platform());
return list.filter(item => {
const matchedOs = !item.platform || item.platform === os.platform();
const matchedArch = !item.arch || item.arch === os.arch();
return matchedOs && matchedArch;
});
};

exports.clientConst = {
Expand Down