refactor: replace dump actions static storages with EnvironmentData #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #202 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 296 296
=========================================
Hits 296 296 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
legendecas
reviewed
Oct 12, 2022
legendecas
approved these changes
Oct 12, 2022
Merged
hyj1991
added a commit
that referenced
this pull request
Oct 22, 2022
Commits: - [2f700fd] docs: update readme (#207) - [f4eb960] feat: support node-v19.x (#206) - [333593e] chore: make test more reliable (#205) - [c574ca2] feat: save Elf BuildId in corefile. (#204) - [b779aa2] feat: support finish profiling before process exit (#203) - [6a1701f] refactor: replace dump actions static storages with EnvironmentData (#202) - [7608a86] fix: ignore clean error (#200) - [2a6eaba] chore: static dispatch on dumpaction (#199) - [7d3fbb2] optimize: take action (#198) PR-URL: #208
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
背景
目前的
dump.cc中实现的采样动作，依赖全局变量处理，存在两个问题：worker_thread/main js thread间并发调用各种 action 不友好此 PR 将 actions 中涉及到的变量放置到
EnvironmentData实例中存储，解决上述问题。测试
局部逻辑重构，依靠现有
command.test.js保证功能没有 break。Reference: #202