Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure config dtor order #177

Merged
merged 2 commits into from
May 9, 2022
Merged

fix: ensure config dtor order #177

merged 2 commits into from
May 9, 2022

Conversation

hyj1991
Copy link
Member

@hyj1991 hyj1991 commented May 8, 2022

  • 退出前 logbypassconfig_store 之后 Join 会导致诸如 logdir 乱码的问题,收敛到 ProcessData 类中保证其在 Join 后销毁

@hyj1991 hyj1991 requested a review from legendecas May 8, 2022 13:55
@codecov
Copy link

codecov bot commented May 8, 2022

Codecov Report

Merging #177 (dc7a4c2) into master (1d81ae2) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #177   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          296       296           
=========================================
  Hits           296       296           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d81ae2...dc7a4c2. Read the comment docs.

@hyj1991 hyj1991 merged commit ef7d4f3 into master May 9, 2022
@hyj1991 hyj1991 deleted the configstore branch May 9, 2022 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants