Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove useless code #175

Merged
merged 2 commits into from
May 6, 2022
Merged

chore: remove useless code #175

merged 2 commits into from
May 6, 2022

Conversation

hyj1991
Copy link
Member

@hyj1991 hyj1991 commented May 5, 2022

由于 [email protected] 最小版本提升至 node-v12.x,此 PR 旨在移除一些已经无需使用的实现,具体为:

  • 将 SRC 和 Node.js 版本相关的条件判断逻辑移除(涉及到 12.x 以下),使实现更加简洁
  • 更新依赖模块至最新版本

@hyj1991 hyj1991 marked this pull request as draft May 5, 2022 23:44
@codecov
Copy link

codecov bot commented May 5, 2022

Codecov Report

Merging #175 (e93a7d8) into master (fb56fe6) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #175   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          296       296           
=========================================
  Hits           296       296           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb56fe6...e93a7d8. Read the comment docs.

@hyj1991 hyj1991 marked this pull request as ready for review May 6, 2022 03:11
@hyj1991 hyj1991 requested a review from legendecas May 6, 2022 03:12
@hyj1991 hyj1991 merged commit eb97ced into master May 6, 2022
@hyj1991 hyj1991 deleted the remove_useless_code branch May 6, 2022 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants