Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support generator core by xprofctl #171

Merged
merged 7 commits into from
May 1, 2022
Merged

feat: support generator core by xprofctl #171

merged 7 commits into from
May 1, 2022

Conversation

hyj1991
Copy link
Member

@hyj1991 hyj1991 commented Apr 28, 2022

  • generator core by xprofctl
  • auto generate core before abort if enable_fatal_error_coredump is true

close #169


演示死循环时动态生成 core 在 llnode 中的解析效果:
image

注意此处生成的是 ulimit -c 是 0,且生成的 core 文件为x-coredump-30500-20220430-0.core,即由 xprofiler 插件在 JS 工作线程死循环时获取。

@hyj1991 hyj1991 marked this pull request as draft April 28, 2022 21:54
@codecov
Copy link

codecov bot commented Apr 28, 2022

Codecov Report

Merging #171 (47dc3d3) into master (b5c4b58) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 47dc3d3 differs from pull request most recent head 5786302. Consider uploading reports for the commit 5786302 to get more accurate results

@@            Coverage Diff            @@
##            master      #171   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          300       301    +1     
=========================================
+ Hits           300       301    +1     
Impacted Files Coverage Δ
lib/configure.js 100.00% <ø> (ø)
xprofiler.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5c4b58...5786302. Read the comment docs.

@hyj1991 hyj1991 marked this pull request as ready for review April 30, 2022 12:52
@hyj1991 hyj1991 merged commit 8ba41fd into master May 1, 2022
@hyj1991 hyj1991 deleted the gen_core branch May 1, 2022 06:54
hyj1991 added a commit that referenced this pull request May 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[WIP] 集成 google coredumper
1 participant