test: check child process exit code #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #136 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 8 8
Lines 287 287
=========================================
Hits 287 287 Continue to review full report at Codecov.
|
legendecas
approved these changes
Feb 11, 2022
legendecas
reviewed
Feb 11, 2022
| return new Promise(resolve => proc.on('close', (code, signal) => resolve({ code, signal }))); | ||
| }; | ||
|
|
||
| exports.checkChildProcessExitInfo = function (expect, exitInfo) { |
There was a problem hiding this comment.
我记得有几个地方是测试 oom fatal error 的，应该是需要指定 exit signal 为 sigabrt 的吧
There was a problem hiding this comment.
我记得有几个地方是测试 oom fatal error 的，应该是需要指定 exit signal 为 sigabrt 的吧
OOM 那边的没加这个测试，只在正常退出的 command 和 logbypass 加了
hyj1991
force-pushed
the
check_exit_code
branch
from
db20ee4 to
aea52b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.