-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remy - v1.2.0 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It only will be used when the ShouldGenerify flag is true
- Remove unnecessary else statement
- Refactor standard_injector to use named returns - Add missing test check
Has a problem with generify duck-interface not found any method
By default, the package will not use reflection, but this will not make to be possible to know the entire path for the file When using reflection, the type will be unique even if it has same package and name
Update the test to use the struct `ReflectionOptions`
Create new errors
To not break compatibility, the exported functions was keep as the same they are, without changing its signature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
documentation
Improvements or additions to documentation
enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reflect
package by default.UseReflectionType
option inConfig
structGetElemKey
method not being able to get the type of the interfaceinterface
andpointer
of the same type were being registered as the same type"Do"
methods: DoGet, DoGetGen, DoGetGenFuncerror
instead of abool