Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remy - v1.2.0 #1

Merged
merged 18 commits into from
Jul 24, 2022
Merged

Remy - v1.2.0 #1

merged 18 commits into from
Jul 24, 2022

Conversation

Jictyvoo
Copy link
Member

  • Replace default type resolution - Now it will not use the reflect package by default.
  • Add UseReflectionType option in Config struct
  • Improve tests coverage
    • Add test to check type resolution for elements with same type-name and package-name from another module
  • Fix GetElemKey method not being able to get the type of the interface
  • Fix an error where interface and pointer of the same type were being registered as the same type
  • Create additional "Do" methods: DoGet, DoGetGen, DoGetGenFunc
  • Refactor the Storage/Injector retrieval to return an error instead of a bool

Jictyvoo added 18 commits July 20, 2022 13:08
It only will be used when the ShouldGenerify flag is true
- Remove unnecessary else statement
- Refactor standard_injector to use named returns
- Add missing test check
Has a problem with generify duck-interface not found any method
By default, the package will not use reflection, but this will not make to be possible to know the entire path for the file

When using reflection, the type will be unique even if it has same package and name
Update the test to use the struct `ReflectionOptions`
To not break compatibility, the exported functions was keep as the same they are, without changing its signature
@Jictyvoo Jictyvoo added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request labels Jul 24, 2022
@Jictyvoo Jictyvoo self-assigned this Jul 24, 2022
@Jictyvoo Jictyvoo merged commit 1af51d8 into main Jul 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant