💀 fix: Injector options not being copied to new injector on constructor

Wrapped-Owls · Jul 24, 2022 · 17c18b4 · 17c18b4
1 parent 9d3fb83
commit 17c18b4
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 9 deletions.
diff --git a/remy/internal/injector/standard_injector.go b/remy/internal/injector/standard_injector.go
@@ -23,6 +23,7 @@ func New(canOverride bool, reflectOpts types.ReflectionOptions, parent ...types.
 	return &StdInjector{
 		allowOverride:   canOverride,
 		parentInjector:  parentInjector,
+		reflectOpts:     reflectOpts,
 		bindStorage:     NewElementsStorage[types.BindKey](canOverride, reflectOpts),
 		instanceStorage: NewElementsStorage[types.BindKey](canOverride, reflectOpts),
 	}

diff --git a/remy/internal/injector/storage.go b/remy/internal/injector/storage.go
@@ -9,24 +9,24 @@ import (
 type (
 	genericAnyMap[T comparable]   map[T]any
 	ElementsStorage[T comparable] struct {
-		allowOverride     bool
-		generifyInterface types.ReflectionOptions
-		namedElements     map[string]genericAnyMap[T]
-		elements          genericAnyMap[T]
+		allowOverride bool
+		reflectOpts   types.ReflectionOptions
+		namedElements map[string]genericAnyMap[T]
+		elements      genericAnyMap[T]
 	}
 )
 
 func NewElementsStorage[T comparable](allowOverride bool, reflectionOptions types.ReflectionOptions) *ElementsStorage[T] {
 	return &ElementsStorage[T]{
-		allowOverride:     allowOverride,
-		generifyInterface: reflectionOptions,
-		namedElements:     map[string]genericAnyMap[T]{},
-		elements:          genericAnyMap[T]{},
+		allowOverride: allowOverride,
+		reflectOpts:   reflectionOptions,
+		namedElements: map[string]genericAnyMap[T]{},
+		elements:      genericAnyMap[T]{},
 	}
 }
 
 func (s ElementsStorage[T]) ReflectOpts() types.ReflectionOptions {
-	return s.generifyInterface
+	return s.reflectOpts
 }
 
 func (s *ElementsStorage[T]) Set(key T, value any) {