Updates to CQL and Library authoring pages #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brynrhodes
commented
Mar 4, 2024
| @@ -73,6 +78,7 @@ In this case, the auhor can for example: | |||
| 2.4. Include any other dynamic values that are needed for the PlanDefinition in the output CQL. | |||
| 2.5. Tag any other expressions needed as internal. | |||
There was a problem hiding this comment.
What is the motivation for the @internal tag? Why not use the private CQL access modifier? More generally, what is the motivation for making it private in the first place?
brynrhodes
commented
Mar 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.