Remove deprecated --process-dependency-links flag from pip install #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcaisse
approved these changes
Feb 25, 2019
There was a problem hiding this comment.
LGTM. It looks like the --process-dependency-links flag was added for djsonb (see f018e77), so I just wanted to test that djsonb was working correctly. I deleted the driver-app container and image and reprovisioned. Then I imported djsonb within a Python shell inside of the container using the new image and it seems to be working fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Removes
pip installflag that was removed in pip version 12. It appears to no longer be necessary (Or had been previously unused).Checklist
Testing Instructions
vagrant provisionCloses PT163762556