Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent address search click propagation to map #729

Merged
merged 2 commits into from
Nov 6, 2018

Conversation

ddohler
Copy link
Contributor

@ddohler ddohler commented Nov 1, 2018

Overview

Prevents clicks in the address search from propagating to the map.

Checklist

  • PR has a descriptive enough title to be useful in changelogs

Notes

Also includes a fix to take out an NFS parameter from the Vagrantfile that causes problems on Ubuntu 18.04. Everyone is using 18.04 except @pcaisse and we've tested this on his machine to confirm that there don't seem to be any problems. If something crops up later we can reconsider.

Testing Instructions

  • Provision or run ./scripts/grunt.sh web serve and navigate to localhost:7000 or localhost:7002, depending.
  • Go to the map page.
  • Click-and-drag on the address search text box, and double-click in the box and on the search button. Confirm that the map does not react to the these clicks.
  • Confirm that the address search maintains existing functionality.

Closes #161460901

@ddohler ddohler merged commit e3f1440 into develop Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants