Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add weather filter feature flag #160200005 #726

Merged
merged 2 commits into from
Oct 23, 2018
Merged

Add weather filter feature flag #160200005 #726

merged 2 commits into from
Oct 23, 2018

Conversation

pcaisse
Copy link
Contributor

@pcaisse pcaisse commented Oct 22, 2018

Overview

Add weather filter feature flag

Checklist

  • PR has a descriptive enough title to be useful in changelogs

Testing Instructions

  • vagrant provision app
  • Go to record list and check that weather filter is shown
  • Edit deployment/ansible/group_vars/development to set web_js_weather_filter_visible: "false"
  • vagrant provision app
  • Go to record list and check that weather filter is not shown

Closes #160200005

@pcaisse pcaisse requested a review from rmartz October 22, 2018 19:58
@rmartz rmartz self-assigned this Oct 23, 2018
rmartz
rmartz approved these changes Oct 23, 2018
View reviewed changes
Copy link
Contributor

@rmartz rmartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pcaisse pcaisse merged commit 9fd4e41 into develop Oct 23, 2018
@pcaisse pcaisse deleted the feature/weather-filter-feature-flag branch October 23, 2018 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmartz rmartz rmartz approved these changes

Assignees

@rmartz rmartz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pcaisse @rmartz