Restart driver-app service only after we have the new image #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes provisioning so that instead of restarting the service after all the tasks have run via the handler, we now do so explicitly in a dedicated task _after_ we pull/build the new image and _before_ we use the app container. Previously, we were running into issues where we would run migrations against the previous version of the container.
ddohler
approved these changes
Sep 7, 2018
There was a problem hiding this comment.
This works well for the driver-app container but it would be good to apply the same fix to the Celery container also. If I vagrant ssh celery and then sudo docker exec -ti driver-celery bash, I'm not able to import itsdangerous even if it works in the driver-app container.
pcaisse
added a commit
that referenced
this pull request
Oct 12, 2018
…ning Restart driver-app service only after we have the new image
pcaisse
added a commit
that referenced
this pull request
Oct 12, 2018
…ning Restart driver-app service only after we have the new image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This changes provisioning so that instead of restarting the service
after all the tasks have run via the handler, we now do so explicitly in
a dedicated task after we pull/build the new image and before we use
the app container.
Previously, we were running into issues where we would run migrations
against the previous version of the container.
Checklist
Testing Instructions
To reproduce the issue on
develop:app/requirements.txt(eg.itsdangerous==0.24)vagrant provision appvagrant ssh appsudo docker exec -it driver-app bashpip freeze | grep its(returns nothing)Now
git stash, check out this branch,git stash popto add your new dep back in and repeat the steps. You should see that the new dependency is now listed.