Include all language options in date-utils #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jisantuc
changed the title
jisantuc
changed the title
jisantuc
force-pushed
the
feature/js/include-all-language-options-in-date-utils
branch
from
679bd3f to
0e121e0
Compare
jisantuc
deleted the
feature/js/include-all-language-options-in-date-utils
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR makes all of the languages that the
gregoriancalendar object knows about in regionaloptions have corresponding entries in our
languageMapin date-utils. It also makes it so that ifthere's a language we don't know about, we just use a default calendar and format.
Testing
[finishes #154032496]