Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make provisioning from scratch work #645

Merged
merged 2 commits into from
Dec 7, 2017

Conversation

jisantuc
Copy link
Member

@jisantuc jisantuc commented Dec 5, 2017

Overview

This PR makes several small changes to make provisioning from scratch cooperate given changes that have occurred in the state of dependencies since this project's dev environment was setup.

Specifically, it explicitly sets bower's registry, separately installs bower, changes the libpq version to something that's in the postgresql PPA, upgrades the base images for some containers to node:4-slim from our old static-core containers.

Testing

  • vagrant provision
  • it should succeed

Copy link
Contributor

@ddohler ddohler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, even though that wasn't all that straightforward, at least the final change set ended up being pretty limited.

@@ -19,7 +19,7 @@ postgresql_port: 5432
postgresql_version: "9.4"
postgresql_package_version: "9.4.*.pgdg14.04+1"
postgresql_support_repository_channel: "main"
postgresql_support_libpq_version: "9.5.*.pgdg14.04+1"
postgresql_support_libpq_version: "9.3.4-1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd feel more comfortable if we find a way to make this at least 9.4; JSONB fields weren't introduced until Postgres 9.4, so it'd be nice if all the versions can match up. I'm not sure whether we're actually using libpq though, so if it's not breaking anything for you locally we can punt and make a separate issue for it.

Copy link
Member Author

@jisantuc jisantuc Dec 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the versions available in the services VM:

$ sudo apt-cache show libpq-dev | grep Version
Version: 10.1-1.pgdg14.04+1
Version: 9.3.20-0ubuntu0.14.04
Version: 9.3.4-1

Nothing bad seems to be happening locally, though I haven't exercised much of the app. It might make sense to open a separate (probably small) issue

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we're relying on the azavea.postgresql-support role to install libpq-dev. The azavea.postgresql role seems to have support for installing a wide range of postgres versions, but the azavea.postgresql-support role doesn't seem to have been updated quite as much. If using 9.4 for the version doesn't work we'll probably need an ops issue to add support to that role.

@@ -1,4 +1,4 @@
FROM quay.io/azavea/static-core:0.1.0
FROM node:4-slim
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once this is merged I think we can let ops know that they can remove this image from Quay; I assume it's not being used anywhere else.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's in their sprint now

Copy link
Contributor

@ddohler ddohler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good; I didn't reprovision from scratch but I tested the node stuff on Tuesday and I know it works.

@@ -97,6 +107,17 @@ To load mock interventions, run `python scripts/load_interventions.py --authz 'T

To generate black spot and load forecast training inputs, run `python scripts/generate_training_input.py /path/to/roads.shp /path/to/records.csv`.

### Costs

You can't request records with associated costs successfully until you configure some costs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, are you saying that all record requests fail if this isn't configured? We should probably make an issue for that if so, it's not supposed to impact the rest of the app.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not all records requests (like, you can hit /api/records/ successfully), but you can't hit /api/records/costs/, which is required for a lot of the app. I think you can view the records list but I don't remember.

@jisantuc jisantuc merged commit 629608a into develop Dec 7, 2017
@jisantuc jisantuc deleted the feature/js/provision-from-scratch branch December 7, 2017 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants