Add FluxUiComponent / FluxUiStatefulComponent #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RavenNumber of Findings: 0 |
Current coverage is 97.02% (diff: 100%)@@ master #10 diff @@
==========================================
Files 26 27 +1
Lines 1186 1205 +19
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 1150 1169 +19
Misses 36 36
Partials 0 0
|
| } | ||
|
|
||
| @Component() | ||
| class BazComponent extends FluxUiStatefulComponent<BazProps> { |
There was a problem hiding this comment.
Should this also take BazState as a param?
| }); | ||
| } | ||
|
|
||
| componentWillUnmount() { |
There was a problem hiding this comment.
#nit should be void
| @@ -14,7 +14,9 @@ | |||
|
|
|||
| library over_react.component_declaration.transformer_helpers; | |||
|
|
|||
| import 'dart:html'; | |||
There was a problem hiding this comment.
Should have a new line after this import
|
+1 |
|
RM +1 manually reviewed dependencies. |
clairesarsam-wf
pushed a commit
to clairesarsam-wf/over_react
that referenced
this pull request
Jan 6, 2017
Add FluxUiComponent / FluxUiStatefulComponent
greglittlefield-wf
pushed a commit
that referenced
this pull request
Jun 19, 2020
CPLAT-5950 Setup basic files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrating the two components that can be used to build OverReact components that talk to w_flux!
FYA @greglittlefield-wf @jacehensley-wf @clairesarsam-wf @joelleibow-wf